Ryan, I think the subport method is the best approach. I’m rewriting both hunspell-de and hunspell-en.
This will also let me give the proper replaced_by for the obsoleted ports. > On Sep 26, 2017, at 10:56 AM, Ryan Schmidt <[email protected]> wrote: > > > On Sep 25, 2017, at 16:31, Marius Schamschula wrote: > >> Marius Schamschula (Schamschula) pushed a commit to branch master >> in repository macports-ports. >> >> >> https://github.com/macports/macports-ports/commit/ada9952556fc64c387ee72cfcb5bfe68171ad85b >> >> The following commit(s) were added to refs/heads/master by this push: >> >> new ada9952 hunspell-de 20161207: split dictionary into variants, >> default to +de_DE > > >> -destroot { >> +pre-destroot { >> xinstall -d -m 755 $installdir >> +} >> + >> +variant de_AT description {Austrian German dictionary} { >> + build.target-append hunspell/de_AT.dic hunspell/de_AT.aff >> + >> + destroot { >> + xinstall -m 644 ${worksrcpath}/hunspell/de_AT.aff $installdir >> + xinstall -m 644 ${worksrcpath}/hunspell/de_AT.dic $installdir >> + } >> +} >> + >> +variant de_CH description {Swiss German dictionary} { >> + build.target-append hunspell/de_CH.dic hunspell/de_CH.aff >> >> - xinstall -m 644 ${worksrcpath}/hunspell/de_AT.aff $installdir >> - xinstall -m 644 ${worksrcpath}/hunspell/de_AT.dic $installdir >> - xinstall -m 644 ${worksrcpath}/hunspell/de_CH.aff $installdir >> - xinstall -m 644 ${worksrcpath}/hunspell/de_CH.dic $installdir >> - xinstall -m 644 ${worksrcpath}/hunspell/de_DE.aff $installdir >> - xinstall -m 644 ${worksrcpath}/hunspell/de_DE.dic $installdir >> + destroot { >> + xinstall -m 644 ${worksrcpath}/hunspell/de_CH.aff $installdir >> + xinstall -m 644 ${worksrcpath}/hunspell/de_CH.dic $installdir >> + } >> } >> >> +variant de_DE description {German dictionary} { >> + build.target-append hunspell/de_DE.dic hunspell/de_DE.aff >> + >> + destroot { >> + xinstall -m 644 ${worksrcpath}/hunspell/de_DE.aff $installdir >> + xinstall -m 644 ${worksrcpath}/hunspell/de_DE.dic $installdir >> + } >> +} >> + >> +default_variants +de_DE > > > Same observation about these variants as made previously about hunspell-en. > > > Also, is there a reason why these should be variants, rather than subports? >
