On 2017-09-27 20:18, Ryan Schmidt wrote:
Most projects on SourceForge organize their files in folders. If dict is such a
project, then you should specify here which folder the file is in, to avoid
redirects. See https://trac.macports.org/wiki/howto/AvoidRedirects
Assuming LIBTOOL is the file to be run, it should be the absolute path
(${prefix}/bin/glibtool).
The default mode for xinstall is 0755, i.e. executable. Conf files should not
be executable, so you should specify mode 0644 (-m 0644).
Moreover, users are expected to edit conf files, but by installing the file in
this way, it is registered to the port, which means any user customizations
will be lost if the port is deactivated or upgraded. Instead, you should
install a sample conf file, and print instructions telling the user how to copy
that sample conf file to the real one. See
https://trac.macports.org/wiki/PortfileRecipes#configfiles
Thanks for the input. Will submit a PR.
I have to admit that for these two ports I was in kind of a hurry and I
didn't go over them a second time as I usually do before submitting a
PR, and ended up overlooking some things.
// Leonardo.
