On Nov 9, 2017, at 20:10, Eitan Adler wrote:

> On 9 November 2017 at 13:55, Ryan Schmidt wrote:
>>> @@ -18,12 +18,11 @@ long_description    p0f is a versatile passive OS 
>>> fingerprinting and \
>>>                     honeypots, for pen-testing, or just for the fun of it.
>>> 
>>> homepage            http://lcamtuf.coredump.cx/p0f3/
>>> -master_sites        ${homepage}releases/ \
>>> -                    ${homepage}releases/old/${major}.x/
>>> +master_sites        ${homepage}/releases/
>> 
>> ${homepage} already ends with a slash so you should not put another slash 
>> after it when using it to define master_sites.
> 
> See the PR. This was intentional since its easier to read and has no 
> redirects.

I don't see any discussion of this in the PR, but either way, I still disagree 
with this change. It is no easier to read than before, and it results in a URL 
with more slashes than needed.



Reply via email to