On Nov 11, 2017, at 15:15, Emre Şafak wrote: > Mojca Miklavec (mojca) pushed a commit to branch master > in repository macports-ports. > > > https://github.com/macports/macports-ports/commit/f03416b55c28500e7c1f688483d33e8b4f00431b > > The following commit(s) were added to refs/heads/master by this push: > > new f03416b sift: new port, replacement for 'grep' built in go > > f03416b is described below > > > commit f03416b55c28500e7c1f688483d33e8b4f00431b > > Author: Emre Şafak <[email protected]> > AuthorDate: Fri Feb 17 17:37:54 2017 -0800 > > > sift: new port, replacement for 'grep' built in go > > > > https://sift-tool.org > > --- > sysutils/sift/Portfile | 92 > ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 92 insertions(+) > > > diff --git a/sysutils/sift/Portfile b/sysutils/sift/Portfile > > new file mode 100644 > > index 0000000..d0193a6 > > --- /dev/null > > +++ b/sysutils/sift/Portfile > > @@ -0,0 +1,92 @@ > > +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; > c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 > > + > > +PortSystem 1.0 > > + > > +# this doesn't work directly because files need to be fetched from multiple > repositories > > +# > > +# PortGroup github 1.0 > > +# github.setup svent sift 0.9.0 v > > + > > +name sift > > +version 0.9.0 > > +platforms darwin > > +categories sysutils > > +license GPL-3+ > > +installs_libs no > > +maintainers {kahuna.com:esafak @esafak} > > +description A fast and powerful open source alternative to grep > > +long_description sift is an alternative that aims for both speed and > flexibility, \ > > + adding features while trying to reach (or even surpass) > the performance \ > > + of the original grep. The additional features include > gitignore support, \ > > + conditions (e.g., match A only when preceded by B within > X lines), \ > > + full multi-core support and multiline matching. > > +homepage http://sift-tool.org
Since the http URL redirects to the https URL, you should list the https URL here to avoid redirects. > +platforms darwin > > +use_zip yes > > + > > +set crypto_hash 2faea14 > > +set nbreader_hash 7cef48da76dca6a496faa7fe63e39ed665cbd219 > > +set flags_version 1.3.0 > > + > > +master_sites https://github.com/svent/sift/archive:sift \ > > + https://github.com/jessevdk/go-flags/archive:flags \ > > + https://github.com/svent/go-nbreader/archive:nbreader \ > > + > https://raw.githubusercontent.com/golang/crypto/${crypto_hash}/ssh/terminal:crypto > > + > > +distfiles v${version}.zip:sift \ > > + v${flags_version}.zip:flags \ > > + ${nbreader_hash}.zip:nbreader \ You have a sift distfile named "v0.9.0.zip" and a go-flags distfile named "v1.3.0.zip". If we mirror these distfiles, what happens in a year, or however long it takes sift to reach version 1.3.0? > + terminal.go:crypto \ > + util_bsd.go:crypto \ > + util.go:crypto Unversioned distfiles are bad. Is there no versioned tarball of this you could have the port download instead? https://trac.macports.org/wiki/PortfileRecipes#unversioned-distfiles Better yet, is there no single tarball you could download that would contain everything? If not, please suggest to the developers that they offer one. > +universal_variant no > > +use_configure no By the way, "univeral_variant no" is set automatically when you set "use_configure no". > +build.cmd go You should use the absolute path to the binary, ${prefix}/bin/go.
