On Dec 21, 2017, at 18:18, Eric Hall wrote:

> ghosthound pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/8ae18caffcb639b88d839a5913985befe28d149a
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 8ae18ca  snappy:     update to 1.1.7         which uses cmake 
> instead of auto*
> 
> 8ae18ca is described below
> 
> 
> commit 8ae18caffcb639b88d839a5913985befe28d149a
> 
> Author: Eric Hall <eric+git [at] darkart.com>

You should configure your git client to use your MacPorts email address for 
commits.


> AuthorDate: Thu Dec 21 16:18:10 2017 -0800
> 
> 
>     snappy:
> 
>       update to 1.1.7
> 
>       which uses cmake instead of auto*


> --- a/archivers/snappy/Portfile
> +++ b/archivers/snappy/Portfile
> @@ -1,13 +1,17 @@
>  # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
>  
>  PortSystem          1.0
> +PortGroup           cmake 1.0

Usually there is no reason to use the cmake 1.0 portgroup anymore and you 
should use the cmake 1.1 portgroup instead.


>  PortGroup           github 1.0
>  
> 
> -github.setup        google snappy 1.1.3
> +github.setup        google snappy 1.1.7
>  categories          archivers
>  platforms           darwin
>  maintainers         nomaintainer
>  license             BSD
> +master_sites        https://github.com/google/snappy/archive/
> +distname            ${version}
> +worksrcdir          ${name}-${version}

Usually there is no reason to override the github portgroup's default 
master_sites, distname, worksrcdir. The whole point of the portgroup is to make 
things easy for you so you don't have to specify a lot of boilerplate in each 
port. When you update to the next version, please remove these overrides and 
allow the portgroup's defaults to be used. Don't change it now, however, 
because the defaults use the "tarball" URL, not the "archive" URL, so the 
checksums would change.


Reply via email to