On Mar 1, 2018, at 09:01, Perry E. Metzger wrote: > On Thu, 1 Mar 2018 08:06:05 -0600 Ryan Schmidt wrote: >>> +github.setup stevenlovegrove Pangolin v0.5 >> >> This causes the port's version to be "v0.5". We don't want the "v" >> in the version, only the number. The correct way to invoke >> github.setup for this situation is: >> >> github.setup stevenlovegrove Pangolin 0.5 v > > Would it be reasonable to add something to the port lint utility to > catch such things and other common issues with the github port > group? It seems like a very large fraction of our ports now come from > github.
Sure, that would be fine. Another possibility is to modify the github portgroup so that it detects this and does the right thing. I think the perl5 portgroup was fixed to do that recently.
