> On Mar 20, 2018, at 18:57, Rainer Müller wrote:
>
> On 2018-03-21 00:02, Rainer Müller wrote:
>> diff --git a/x11/wine/Portfile b/x11/wine/Portfile
>> index 9a08944..539688e 100644
>> --- a/x11/wine/Portfile
>> +++ b/x11/wine/Portfile
>> @@ -239,7 +239,12 @@ compiler.blacklist-append macports-gcc-*
>>
>> if {[variant_isset universal]} {
>> # wine for 64-bit requires clang >= 3.8
>> - compiler.blacklist-append {clang < 800}
>> + compiler.blacklist-append {clang < 800} \
>> + macports-clang-3.3 \
>> + macports-clang-3.4 \
>> + macports-clang-3.5 \
>> + macports-clang-3.6 \
>> + macports-clang-3.7 \
>> }
>>
>> platform darwin {
>>
> This is now still picking up gcc-apple-4.2 on OS X 10.8
Then blacklist it.
> and it is getting tedious to find a solution by committing for the buildbot.
If you don't have a local system to test on, then committing and checking
buildbot results is the only alternative available today.
> Normally I would not bother to fix unsupported systems, but this time I am
> also the one who broke it... ;-)
> Do we have any better way to specify the need for clang >= 3.8?
No; the above is currently the correct way to do it. It will be a little
simpler if we implement https://trac.macports.org/ticket/56093.
> I tried setting compiler.whitelist as well, but it only lead me to the "All
> compilers are either blacklisted or unavailable" message.
Generally, do not use compiler.whitelist. Use compiler.blacklist instead, and
if all compilers are then blacklisted, add a suitable alternative to
compiler.fallback.
> If there is no way, we should probably just disable the 64-bit build of wine
> for macOS <= 10.8.
Obviously if there is *no way* to build it on older systems then you have to
prevent it. But it does not sound like it is impossible at this point, so
please don't do that yet.
