On 2018-4-8 03:44 , Ryan Schmidt wrote:
> 
> On Apr 7, 2018, at 12:05, Eric A. Borisch wrote:
> 
>> +        eval [subst {
> 
> This usage of "eval" was recently removed from other ports. Please look up 
> what changes were done, and make them here as well:
> 
> https://github.com/macports/macports-ports/commit/d41a0388cfdf7e6dbf3353d89939eaff876945ec
> 
> Use of "eval" should be avoided where possible.

This is an antipattern not because it uses eval (though eval is almost
never needed), but because it's only using it to undo an extra level of
quoting that could simply not be added in the first place.

- Josh

Reply via email to