Doing this should prevent the MR being merged, and make it clear the author is 
still working on something, but want to submit the MR now for other reasons 
(like not to forget it, or start to get comments etc.). I use this regularly in 
other systems at work and it works really well...

We should allow (encourage even) WIP PRs to be submitted, when the work is in a 
state that warrants it.

Chris

Personally i would think those would better be trac tickets, as that model 
seems to work better for commenting, and working things out, but that could be 
just my preference.

Sorry, but I strongly disagree. If the PR involves a half finished update, then its much better to submit that in its current state, and invite comments on the bits the submitter wants comments on. Further commits (or not) can then be made until the submission is in a state it can be unWIP'ed and merged. At which point its already ready as an MR to submit. To first do this in trac then move it over is just a huge waste of time, plus trac is no where near as convenient for making specific comments on parts of a diff as github is.

Personally, I would like to see MacPorts go in exactly the opposite direction, so migrate away from using trac for anything much. I also happen to think, one way or another this will naturally happen as people get used to, and see all the advantages, of doing everything within github...

Reply via email to