On Mon, 7 May 2018 12:58:04 +0000 Zero King <[email protected]> wrote:
> On Mon, May 07, 2018 at 08:41:30AM -0400, Perry E. Metzger wrote:
> >When pull requests come in, users are asked to fill out a short
> >checklist. I'd like to add a reminder to squash your commits into
> >it -- this has become a frequent issue with pull requests from new
> >contributors.  
> 
> I think we should consider enabling squash merging in our repo
> instead, squashing commits is not an easy task for git beginners.

Maybe. The template change is easy.

> Also if the PR allows edits from maintainers (enabled by default),
> we can force push and update that PR ourselves.

Yah. Unfortunately people often accidentally do a PR from their
master branch. I've put in a comment mentioning not to do that, but
if there's some machinery to make people use a branch and not master
that would be cool.

Perry
-- 
Perry E. Metzger                [email protected]

Reply via email to