> On Jul 15, 2018, at 1:30 PM, Perry E. Metzger <[email protected]> wrote:
>
> On Sat, 14 Jul 2018 21:07:38 -0700 Eitan Adler <[email protected]>
> wrote:
>> "It greatly increases build time so it must be disabled by default."
>> is not good justification. In fact, that enabling optimization
>> increases build time, is good motivation to *enable* it by default,
>> so that most users will be able to use binary packages.
>
> It can take tens of minutes instead of a minute or two to build
> when you turn it on. That's quite different from the fairly slight
> change that normal optimization brings. Indeed, for some people, the
> extra time for the build may significantly exceed the sum of the gains
> they ever experience running Python over the lifetime of the binaries.
>
> It is thus now available for users, but not the default.
It seems to me that most people, if they are using the binary builds, would
benefit from this change, so having the build bot do the compile once for all
users seems like a good idea. So unless there’s places where the optimization
hurts, I suggest enabling it by default.
Blair
