On 2018-11-18 03:47 , Marcus Calhoun-Lopez wrote: > A recent update to libedit is causing issues with Python [1]. > I have tracked down the upstream changes that caused the problems and > reverted them in a pull request [2]. > I will attempt to reach out to the upstream developers, but I cannot quite > tell if upstream is a project [3] or an operating system [4].
The ultimate upstream is an operating system, but there's also a middle-man who maintains a portable distribution of this one library from that operating system. > Would anyone more knowledgeable than I about libedit like to comment before I > merge the pull request? > If at all possible, I would like to not carry these patches around forever. The changes seem reasonable as far as they go. They seem to have been fixing a legitimate issue with the first one, but it's definitely incompatible with what python does. It removes and reinstalls the callback between every input line, and doesn't want to lose all the state (including history) every time it does that. This might be considered a strange approach, but it does work fine with gnu readline, which is what they're emulating. With the second one, they seem to have just not thought through the fact that things other than filenames might be completed. It's not a bad idea, but the escaping somehow needs to only be applied to actual filenames. - Josh
