Hey,
> 1) you’re missing the “license” field (you should have gotten a warning about > this when doing “port lint —nitpick py-upt”) > 2) the value for “homepage” seems incorrect > 3) since upt is a tool (i.e., run on the command line and not really used as > a library by other packages) only one Python version would suffice. I'd > suggest to only add “37” after “python.versions” > 4) the category of your dependencies is not completely correct. Indeed, > py-setuptools is a build-dependency, but py-spdx-lookup is not. The latter is > needed when using upt and should, therefore, be listed as > “depends_lib-append”. > 5) please add "supported_archs noarch” after “platforms"; since there are > no architecture dependent files installed (as is often the case for Python > scripts) > 6) a little bit nitpicking: (i) add a new line after the modeline, (2) add > “revision 0” after “version” I have edited the files as suggested. One issue I faced while going over the checklist for PR is: When I try installing upt with trace mode (-vst), it fails but other than that it installs properly. Any way to fix this issue? Error: ---> Building upt Executing: cd "/opt/local/var/macports/build/_Users_kiteretsu_Downloads_GSoc_upt_testports_python_upt/upt/work/upt-0.6" && /opt/local/Library/Frameworks/Python.framework/Versions/3.7/bin/python3.7 setup.py --no-user-cfg build sh: /opt/local/Library/Frameworks/Python.framework/Versions/3.7/bin/python3.7: No such file or directory Command failed: cd "/opt/local/var/macports/build/_Users_kiteretsu_Downloads_GSoc_upt_testports_python_upt/upt/work/upt-0.6" && /opt/local/Library/Frameworks/Python.framework/Versions/3.7/bin/python3.7 setup.py --no-user-cfg build Exit code: 127 Warning: The following existing file was hidden from the build system by trace mode: /opt/local/Library/Frameworks/Python.framework/Versions/3.7/bin/python3.7 Thanks, Karan Sheth -- <https://www.somaiya.edu> <http://www.somaiya-ayurvihar.org> <http://nareshwadi.org> <http://somaiya.com> <http://www.helpachild.in> <http://nareshwadi.org>
