On Apr 2, 2020, at 09:39, SAPTARSHI MUKHERJEE wrote: > Thanks again for assigning to me the issue #60219 related to port ehcache. It > helped me develop a much better understanding about a few things related to > the portfile and the ports. > > I've made the necessary changes that fetches the new jar file appropriately, > checks with updated checksum values correctly, and I've removed the Kaffe > dependency, replacing it with the Java Portgroup. It has given expected > results on testing, however following are few things that I'd like to know:- > > 1) Does this port still need to depend on apache-ant? Facing an error in > apache-ant, I've removed the statement, which helped me get rid of the > build-related error. If the apache-ant still needs to be retained, I'll have > to look into it to fix the error that was like "Command failed : ant clean > dist". Please tell me if the dependency becomes redundant after inclusion of > Java portgroup or is still important.
The Java portgroup doesn't mention anything about ant, so I don't know. If the port builds in trace mode without a dependency on ant then I guess it doesn't need it anymore. You can also consult any installation documentation that this project might provide; hopefully they would tell you what their dependencies are. > 2) On running the command "sudo port test", when it enters the testing phase, > it says "Failed to test ehcache: ehcache has no tests turned on. see > 'test.run' in portfile(7)". I feel it is not related to the correctness of > the portfile code, but may please guide me in how I can get rid of this issue > and be able to test it successfully. I'm submitting the main.log for your > kind reference. "sudo port test" will not work unless you put "test.run yes" into the Portfile. Then "sudo port test" will build the project and then run whatever command is implied by test.cmd and test.args. The default values set by MacPorts may not be appropriate to this project; if not, you'll need to modify them to whatever values this project needs. You'd have to figure out what those are. This is all only if the project actually has tests and if you want to enable users to run them. As you say, that's not related to the ticket and is not required.
