Hi,

> On 13 May 2020, at 3:05 pm, Jason Liu <[email protected]> wrote:
> 
> Maybe it would be better to start by submitting one PR for one isolated port. 
> We can then give you feedback on anything that might need to be changed and 
> merge it. This may enable you to make similar changes in your other ports 
> before submitting them. Then submit a PR for a second port. At some point, 
> once your PRs are getting accepted with no changes, you could submit two or 
> more ports together in a single PR, if the ports are similar and not too 
> complex
> 
> Actually I already started the process more than a week ago. The first 
> library, Partio, was accepted and merged yesterday:
> 
> https://github.com/macports/macports-ports/pull/7006 
> <https://github.com/macports/macports-ports/pull/7006>
> 
> But of course, Open Shading Language (OSL), the library that depends on 
> Partio, failed the Travis CI build, since Partio didn't exist in the ports 
> tree when I submitted it at the same time:
> 
> https://github.com/macports/macports-ports/pull/7007 
> <https://github.com/macports/macports-ports/pull/7007>
> 
> This is what prompted me to write my original question, because it seems that 
> a piece of software like Blender which has a complex dependency tree could 
> potentially take weeks or months for all of the new libraries to get accepted 
> into MacPorts.

That might well be true I am afraid. The point though is simply putting all the 
changes into a single PR will not help. If anything it makes it worse as large 
PRs with a lot of changes are harder to review. Smaller bitesize pieces are 
much easier to deal with, one step at a time.

Chris

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to