> On Jul 6, 2020, at 11:54 AM, Ryan Schmidt <[email protected]> wrote: > > I can't provide any advice on bazel, but I can give a few comments on the > portfile: > > >>> # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; >>> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 >>> >>> PortSystem 1.0 >>> PortGroup compilers 1.0 > > Are you using this portgroup? I didn't see you using the compilers.choose or > compilers.setup procs for example. > > >>> PortGroup xcodeversion 1.0 > > You're not using this portgroup so you can remove it. It only provides the > minimum_xcodeversions option and you're not using that. You're only using the > $xcodeversion variable which is defined by base and is not related to this > portgroup. >
Thanks, both fixed. > >>> homepage https://github.com/deepmind/tree >>> distname ${github.project}-${version} > > Usually the defaults of the github portgroup should be sufficient. But you're > mixing it with the python portgroup, and it's possible that the python > portgroup is overwriting the github portgroup's settings for these. Is that > what you're seeing? I added this so that worksrcdir has the name of the version, not the GitHub commit hash, which is easier to debug. >>> # require c++14 >>> compiler.cxx_standard 2014 >>> >>> # The oldest Xcode version to use default Xcode compiler >>> # https://github.com/tensorflow/tensorflow/issues/39262 >>> set tf_min_xcode 10.2 >>> compiler.blacklist-append {clang < 1001} >>> # Work out if we should be using macports clang >>> set use_mp_clang [ expr ( [ string match macports-clang-* >>> ${configure.compiler} ] || [ vercmp ${xcodeversion} ${tf_min_xcode} ] < 0 ) >>> ] > > Do the reasons why tensorflow is requiring such a new compiler also apply to > this new port? Not sure. I’m simply trying to adapt py-tensorflow’s successful bazel-based build to a Python port that also uses bazel.
smime.p7s
Description: S/MIME cryptographic signature
