An understandable presumption in itself, however there was another force
push after dluke's last comment, so the changes that ended up being
merged had not been reviewed by the maintainer.
This was pretty clearly just a misunderstanding, but maybe we should
clarify the policies to only allow merging by others (before timeout)
when there is a non-stale approving review from the maintainer.
- Josh
On 2/11/2023 09:12, Perry E. Metzger wrote:
Your communication in the thread was:
> ideally we'll get confirmation from @barracuda156
<https://github.com/barracuda156> that we've got a working solution
before we merge as well.
After he verified that it was working for him, I presumed you were okay
with it being committed.
Perry
On 11/1/23 17:22, Daniel J. Luke wrote:
Perry - I had not yet signed off on this PR.
The port is not openmaintainer.
Please refrain from making changes to non-openmaintainer ports without the
maintainer's approval.
On Nov 1, 2023, at 12:48 PM, Christopher Chavez via
macports-changes<[email protected]> wrote:
Perry E. Metzger (pmetzger) pushed a commit to branch master
in repository macports-ports.
