On 24/10/2025 15:07, Chris Jones via macports-dev wrote:
On 24 Oct 2025, at 2:48 am, Renee Otten <[email protected]> wrote:
AFAIK: the body of the commit message is for linking relevant Trac tickets, and
adding some “minor” changes that don’t warrant an additional commit but don’t
fit in the the summary either. That’s what I follow when committing things
myself to the repository and when merging PRs.
Personally, when merging PRs if the author went to the effort of adding
additional information in the body of the commit messages I see no reason for
the maintainer committing it to just remove that information. I certainly would
never do that. As long as the summary line follows our guidelines, whatever
they choose to add after that is for me up to the commit author. I feel its
just a bit antagonistic to remove it for no reason.
For reference, our guidelines are here:
<https://trac.macports.org/wiki/CommitMessages>
Straightforward updates to a new upstream version often don't need any
further explanation, and test results are beyond what I would tend to
include, but in general over-explaining is better than under-explaining.
- Josh
