Dear list,
these two patches make my mbp successfully suspend/resume even when the
piix driver is loaded (if that one is loaded and the ide.patch is not
applied the machine hangs on suspend - i.e. never suspends).
The sci_en_mbp* patch fixes this irq9 storm after resume for mbp (which
appears on macbooks too).
Apply on top what is in mactel-patches.
Please note that Till Straumann is the author of the ide.patch and also
noticed that acpi does not work after resume without a sci_en patch (at
a time where I did not even own a mbp).
While I think the sci_en patch should be added immediately I am not so
sure whether the ide.patch is the right thing to do...
Anyway using this patch this machine survived several suspend/resume
cycles with or w/o a disk in the drive and I've got a report from a mb
owner that he could not reliably suspend w/o the patch + when the piix
module is loaded.
Soeren.
--- a/drivers/ide/ide-io.c 2006-10-26 09:17:25.000000000 +0200
+++ b/drivers/ide/ide-io.c 2006-11-05 14:02:06.000000000 +0100
@@ -1006,7 +1006,8 @@
ide_check_pm_state(drive, rq);
SELECT_DRIVE(drive);
- if (ide_wait_stat(&startstop, drive, drive->ready_stat, BUSY_STAT|DRQ_STAT, WAIT_READY)) {
+ /* Don't wait if we are going to sleep; ACPI seems to mark the channel busy; T.S, 2006/09 */
+ if ( !drive->blocked && ide_wait_stat(&startstop, drive, drive->ready_stat, BUSY_STAT|DRQ_STAT, WAIT_READY)) {
printk(KERN_ERR "%s: drive not ready for command\n", drive->name);
return startstop;
}
--- a/drivers/acpi/sleep/main.c 2006-11-05 13:55:28.000000000 +0100
+++ b/drivers/acpi/sleep/main.c 2006-10-26 18:10:40.000000000 +0200
@@ -226,6 +226,11 @@
.ident = "Apple MacBook",
.matches = {DMI_MATCH(DMI_PRODUCT_NAME, "MacBook1,1"),},
},
+ {
+ .callback = init_ich7_sci_en_quirk,
+ .ident = "Apple MacBook Pro",
+ .matches = {DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro1,1"),},
+ },
{},
};
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Mactel-linux-devel mailing list
Mactel-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mactel-linux-devel
