On Tue, Nov 28, 2006 at 20:58:18 +0100, Tino Keitel wrote:
> On Tue, Nov 28, 2006 at 20:50:30 +0100, Tino Keitel wrote:
> > On Sun, Nov 26, 2006 at 02:49:03 -0800, [EMAIL PROTECTED] wrote:
> > > Revision: 63
> > >           http://svn.sourceforge.net/mactel-linux/?rev=63&view=rev
> > > Author:   nboichat
> > > Date:     2006-11-26 02:49:01 -0800 (Sun, 26 Nov 2006)
> > > 
> > > Log Message:
> > > -----------
> > > Patches for 2.6.19-rc6.
> > > 
> > > Added Paths:
> > > -----------
> > >     trunk/kernel/mactel-patches-2.6.19/
> > >     trunk/kernel/mactel-patches-2.6.19/Changelog
> > >     trunk/kernel/mactel-patches-2.6.19/acpi-blacklist-fix.patch
> > >     trunk/kernel/mactel-patches-2.6.19/applesmc.patch
> > 
> > This doesn't work for me on the mini:
> > 
> > applesmc: supported laptop not found!
> > applesmc: driver init failed (ret=-19)!
> > 
> > This worked with 2.8.18. How comes? Interdiff only shows changes in the
> > kernel config help section.
> 
> Erm, I made a diff between my 2.6.18 and 2.6.19-rc6 source trees and it
> seems like there is a lot of stuff missing, e.g. the whole temperature
> stuff.

Obviously, the latest applesmc patch was never tested on a mini. I
fixed the DMI match to test for a lowercase product string, and now the
module loads here:

applesmc: Apple Macmini detected:
applesmc:  - Model without accelerometer
applesmc:  - Model without light sensors and backlight
applesmc:  - Model with 2 temperature sensors
applesmc: device successfully initialized.
applesmc: 1 fans found.
applesmc: driver successfully loaded.

Regards,
Tino
--- linux-2.6.18.2/drivers/hwmon/applesmc.c     2006-11-29 10:56:40.436933134 
+0100
+++ 2.6.19/drivers/hwmon/applesmc.c     2006-11-29 10:52:13.191378059 +0100
@@ -783,9 +783,9 @@
                  DMI_MATCH(DMI_BOARD_VENDOR,"Apple"),
                  DMI_MATCH(DMI_PRODUCT_NAME,"MacBook") },
                        (void*)&applesmc_dmi_data[1]},
-               { applesmc_dmi_match, "Apple MacMini", {
+               { applesmc_dmi_match, "Apple Macmini", {
                  DMI_MATCH(DMI_BOARD_VENDOR,"Apple"),
-                 DMI_MATCH(DMI_PRODUCT_NAME,"MacMini") },
+                 DMI_MATCH(DMI_PRODUCT_NAME,"Macmini") },
                        (void*)&applesmc_dmi_data[2]},
                { .ident = NULL }
        };
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Mactel-linux-devel mailing list
Mactel-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mactel-linux-devel

Reply via email to