On Mon, 2008-10-27 at 21:40 +0000, rydberg wrote: > It *is* possible to make the patch smaller, by 18 lines, by leaving the > if statements untouched, like this: <snip> > However, the resulting code looks rather artifical. Would you prefer a > patch base on the above?
Yes, I think that's better. Not because the code is better, but because the patch is smaller and it's more obvious what you're changing. I find that in general, when submitting patches upstream, it is better to be small and try your best to show exactly what you're changing. Those patches tend to get accepted faster. (and sometimes at all) -- GPM unresponsive for two minutes after startup on Macbooks https://bugs.launchpad.net/bugs/289520 You received this bug notification because you are a member of Mactel Support, which is a direct subscriber. Status in Mactel Support: Fix Released Status in “gnome-power-manager” source package in Ubuntu: In Progress Bug description: Binary package hint: gnome-power-manager Many of the recent Apple MacBooks have a large number of LCD backlight levels. The GPM uses XRandR to modify the backlight. However, the gpm-brightness-xrandr smooth brightness function does not take the number of brightness levels into account. On recent Macbooks, this leads to some 20000 brightness-set calls on startup, an activity that takes about one and a half minute. During this time, GPM is not responsive. Attached is a patch that introduces scaled stepping, which fixes the problem. _______________________________________________ Mailing list: https://launchpad.net/~mactel-support Post to : [email protected] Unsubscribe : https://launchpad.net/~mactel-support More help : https://help.launchpad.net/ListHelp
