#434: Add top-level "rpm" target to build rpms
--------------------------------------------+-------------------------------
      Reporter:  [EMAIL PROTECTED]  |       Owner:     
          Type:  enhancement                |      Status:  new
      Priority:  minor                      |   Milestone:     
     Component:  madwifi: makefiles         |     Version:     
    Resolution:                             |    Keywords:     
Patch_attached:  0                          |  
--------------------------------------------+-------------------------------
Comment (by [EMAIL PROTECTED]):

 Feedback from Michael Renzmann:

 "On Sun, 2006-02-19 at 22:00 +0000, Richard Dawe wrote:
 >> I'd like this to be committed to svn. Let me know what work it needs
 for
 >> that to happen.

 From a technical pov I'd ask you to resubmit your patch by opening a new
 ticket and attaching your patch to it. In addition, your patch will need
 to be signed off by you before it can be committed to the repository.

 Apart from what Axel Thimm already mentioned about adding the user name
 into the rpm: replacing @@DDAY@@ with $(SNAPSHOT) is not correct. From the
 script that generates the tarballs:

 {{{
             cat $TARBALL_NAME/$SPECFILE_IN | \
                 sed -e "s/@@SVNREL@@/$newrev/" \
                 -e "s/@@DDAY@@/$(date +%Y%m%d)/" \
                 -e "s/@@BRANCH@@/trunk/" > $TARBALL_NAME/$SPECFILE_OUT

 }}}

 In addition we should find a way to properly set @@BRANCH@@ (easy for now,
 since the rpm stuff is included only in trunk - but that will change
 sooner or later)."

-- 
Ticket URL: <http://madwifi.org/ticket/434>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity

Reply via email to