#508: Setting TXpower Issues
-----------------------------------+----------------------------------------
      Reporter:  [EMAIL PROTECTED]  |       Owner:  dyqith                      
        
          Type:  defect            |      Status:  assigned                     
       
      Priority:  major             |   Milestone:  version 0.9.0 - move to new 
codebase
     Component:  madwifi: driver   |     Version:  trunk                        
       
    Resolution:                    |    Keywords:                               
       
Patch_attached:  1                 |  
-----------------------------------+----------------------------------------
Comment (by mrenzmann):

 Some questions/comments about that patch:

 Why do you move set_node_txpower() to if_ath.c?

 Please add a "XXX:" to the initial comment of ath_update_txpower(), so
 that it's clear that the locking is still needed.

 And one minor formatting issue: please use
 {{{
 if (blabla) {
    ...
 } else {
    ...
 }
 }}}
 rather than
 {{{
 if (something)
 {
    ...
 }
 }}}

-- 
Ticket URL: <http://madwifi.org/ticket/508>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity

Reply via email to