#538: wlanunit <-> ifr_name linkage not valid
------------------------------------+---------------------------------------
Reporter: [EMAIL PROTECTED] | Owner: mrenzmann
Type: enhancement | Status: assigned
Priority: major | Milestone: version 0.9.x - progressive
release candidate phase
Component: madwifi: other | Version: trunk
Resolution: | Keywords:
Patch_attached: 1 |
------------------------------------+---------------------------------------
Comment (by dyqith):
The patch looks good, but a few comments:
1) since you're already modifying this file, can you also close() all the
parts where a socket is used ? i.e. getsocket() and socket()
2) Your unit checking doesn't take into account of the user's unit.
i.e. wlanconfig ath20001 create wlandev wifi0 wlanmode ap (creates ath0,
but shouldn't)
3) wlanconfig ath202 create -u wlandev wifi0 wlanmode ap
Doesn't print out the interface created like the regular modes. (it
should)
4) Maybe, don't use -u, but give it a word "nounit", or "unnumbered"
etc... -u means more like it can be a parameter after the command (which
it really can't be right now)
That's all the comments I have for now.
Otherwise, I think this is a very good patch to be working on.
--
Ticket URL: <http://madwifi.org/ticket/538>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity
