#625: patches/2.6/install.sh fails
----------------------------------------+-----------------------------------
Reporter: [EMAIL PROTECTED] | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: madwifi: makefiles | Version: trunk
Resolution: | Keywords:
Patch_attached: 0 |
----------------------------------------+-----------------------------------
Changes (by mrenzmann):
* version: => trunk
Old description:
> {{{
> If the current (uname -a) kernel's build directory is missing,
> the script fails regardless of the parameter given.
>
> [EMAIL PROTECTED] src]# uname -a
> Linux linux 2.6.16.16 #1 SMP PREEMPT Sat May 13 15:09:02 EDT 2006 i686
> i686 i386 GNU/Linux
> [EMAIL PROTECTED] src]# dir /lib/modules/
> total 8
> drwxr-xr-x 3 root root 4096 May 14 18:51 2.6.16.15
> drwxr-xr-x 3 root root 4096 May 15 14:51 2.6.16.16
> [EMAIL PROTECTED] src]# ls -l
> total 52748
> lrwxrwxrwx 1 root root 16 May 16 15:38 linux -> linux-2.6.16.13/
> drwxrwxrwx 19 root root 4096 May 2 17:38 linux-2.6.16.13
> -rw-r--r-- 1 root root 40837424 May 2 21:48 linux-2.6.16.13.tar.bz2
> drwxr-xr-x 14 root root 4096 May 16 15:37 madwifi-ng-r1546-20060511
> drwxr-xr-x 14 root root 4096 May 16 15:39 madwifi-ng-r1552-20060515
> [EMAIL PROTECTED] src]# cd madwifi-ng-r1546-20060511/patches/2.6
> [EMAIL PROTECTED] 2.6]# ./install.sh /usr/src/linux-2.6.16.13
> Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/ath
> Copy ath driver bits...
> /bin/sh: line 0: cd: /lib/modules/2.6.16.16/build: No such file or
> directory
> make: Entering directory `/usr/src/madwifi-ng-r1546-20060511'
> Makefile.inc:95: *** /lib/modules/2.6.16.16/build is missing, please set
> KERNELPATH. Stop.
> make: Leaving directory `/usr/src/madwifi-ng-r1546-20060511'
> [EMAIL PROTECTED] src]# cd madwifi-ng-r1552-20060515/patches/2.6
> [EMAIL PROTECTED] 2.6]# ./install.sh /usr/src/linux-2.6.16.13
> Copy ath driver bits...
> /bin/sh: line 0: cd: /lib/modules/2.6.16.16/build: No such file or
> directory
> make: Entering directory `/usr/src/madwifi-ng-r1552-20060515'
> Makefile.inc:95: *** /lib/modules/2.6.16.16/build is missing, please set
> KERNELPATH. Stop.
> make: Leaving directory `/usr/src/madwifi-ng-r1552-20060515'
>
> The following seems to make things work somewhat better:
>
> diff -urN madwifi-ng-r1546-20060511/patches/2.6/install.sh
> madwifi/patches/2.6/install.sh
> --- madwifi-ng-r1546-20060511/patches/2.6/install.sh 2006-04-30
> 19:18:38.000000000 -0400
> +++ madwifi/patches/2.6/install.sh 2006-05-15 14:20:34.000000000
> -0400
> @@ -11,7 +11,7 @@
> #
> KERNEL_VERSION=`uname -r | \
> awk '{ split($0,a,"."); print a[1] "." a[2]; }'`
> -KERNEL_PATH=${1:-/lib/modules/${KERNEL_VERSION}/build}
> +export KERNELPATH=${1:-/lib/modules/${KERNEL_VERSION}/build}
>
> MKDIR()
> {
> @@ -56,7 +56,7 @@
> SRC_COMPAT=${DEPTH}/include
> test -d ${SRC_COMPAT} || { echo "No compat directory ${SRC_COMPAT}!";
> exit 1; }
>
> -WIRELESS=${KERNEL_PATH}/drivers/net/wireless
> +WIRELESS=${KERNELPATH}/drivers/net/wireless
> test -d ${WIRELESS} || { echo "No wireless directory ${WIRELESS}!"; exit
> 1; }
>
> DST_ATH=${WIRELESS}/ath
> @@ -107,7 +107,7 @@
> fi
>
> DST_NET80211=${WIRELESS}/net80211
> -DST_DOC=${KERNEL_PATH}/Documentation
> +DST_DOC=${KERNELPATH}/Documentation
> MKDIR ${DST_NET80211}
> echo "Copy net80211 bits..."
> FILES=`ls ${SRC_NET80211}/*.[ch] | sed '/mod.c/d'`
>
> [EMAIL PROTECTED] src]# cd madwifi-ng-r1552-20060515
> [EMAIL PROTECTED] madwifi-ng-r1552-20060515]# patch -p1 -s < ../madwifi-
> kernel.patch
> [EMAIL PROTECTED] madwifi-ng-r1552-20060515]# cd patches/2.6
> [EMAIL PROTECTED] 2.6]# ./install.sh /usr/src/linux-2.6.16.13
> Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/ath
> Copy ath driver bits...
> make: Entering directory `/usr/src/madwifi-ng-r1552-20060515'
> if [ -d .svn ]; then \
> ver=`svnversion -nc . | sed -e 's/^[^:]*://;s/[A-Za-z]//'`; \
> elif [ -s SNAPSHOT ]; then \
> ver=`sed -e '/^Revision: */!d;s///;q' SNAPSHOT`; \
> else \
> ver=`date +%F`; \
> fi; \
> echo "#define SVNVERSION \"$ver\"" > svnversion.h
> make: Leaving directory `/usr/src/madwifi-ng-r1552-20060515'
> Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/_ath_hal
> Copy ath_hal bits...
> Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/_ath_rate
> Copy ../../ath_rate/onoe bits...
> Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/hal
> Copy hal bits...
> Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/hal/linux
> Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/hal/public
> cp: cannot stat `../../hal/public/*.hal': No such file or directory
>
> Note the other error above. This doesn't happen in 1546, but does in
> 1550.
> }}}
New description:
If the current (uname -a) kernel's build directory is missing,
the script fails regardless of the parameter given.
{{{
[EMAIL PROTECTED] src]# uname -a
Linux linux 2.6.16.16 #1 SMP PREEMPT Sat May 13 15:09:02 EDT 2006 i686
i686 i386 GNU/Linux
[EMAIL PROTECTED] src]# dir /lib/modules/
total 8
drwxr-xr-x 3 root root 4096 May 14 18:51 2.6.16.15
drwxr-xr-x 3 root root 4096 May 15 14:51 2.6.16.16
[EMAIL PROTECTED] src]# ls -l
total 52748
lrwxrwxrwx 1 root root 16 May 16 15:38 linux -> linux-2.6.16.13/
drwxrwxrwx 19 root root 4096 May 2 17:38 linux-2.6.16.13
-rw-r--r-- 1 root root 40837424 May 2 21:48 linux-2.6.16.13.tar.bz2
drwxr-xr-x 14 root root 4096 May 16 15:37 madwifi-ng-r1546-20060511
drwxr-xr-x 14 root root 4096 May 16 15:39 madwifi-ng-r1552-20060515
[EMAIL PROTECTED] src]# cd madwifi-ng-r1546-20060511/patches/2.6
[EMAIL PROTECTED] 2.6]# ./install.sh /usr/src/linux-2.6.16.13
Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/ath
Copy ath driver bits...
/bin/sh: line 0: cd: /lib/modules/2.6.16.16/build: No such file or
directory
make: Entering directory `/usr/src/madwifi-ng-r1546-20060511'
Makefile.inc:95: *** /lib/modules/2.6.16.16/build is missing, please set
KERNELPATH. Stop.
make: Leaving directory `/usr/src/madwifi-ng-r1546-20060511'
[EMAIL PROTECTED] src]# cd madwifi-ng-r1552-20060515/patches/2.6
[EMAIL PROTECTED] 2.6]# ./install.sh /usr/src/linux-2.6.16.13
Copy ath driver bits...
/bin/sh: line 0: cd: /lib/modules/2.6.16.16/build: No such file or
directory
make: Entering directory `/usr/src/madwifi-ng-r1552-20060515'
Makefile.inc:95: *** /lib/modules/2.6.16.16/build is missing, please set
KERNELPATH. Stop.
make: Leaving directory `/usr/src/madwifi-ng-r1552-20060515'
}}}
The following seems to make things work somewhat better:
{{{
diff -urN madwifi-ng-r1546-20060511/patches/2.6/install.sh
madwifi/patches/2.6/install.sh
--- madwifi-ng-r1546-20060511/patches/2.6/install.sh 2006-04-30
19:18:38.000000000 -0400
+++ madwifi/patches/2.6/install.sh 2006-05-15 14:20:34.000000000
-0400
@@ -11,7 +11,7 @@
#
KERNEL_VERSION=`uname -r | \
awk '{ split($0,a,"."); print a[1] "." a[2]; }'`
-KERNEL_PATH=${1:-/lib/modules/${KERNEL_VERSION}/build}
+export KERNELPATH=${1:-/lib/modules/${KERNEL_VERSION}/build}
MKDIR()
{
@@ -56,7 +56,7 @@
SRC_COMPAT=${DEPTH}/include
test -d ${SRC_COMPAT} || { echo "No compat directory ${SRC_COMPAT}!";
exit 1; }
-WIRELESS=${KERNEL_PATH}/drivers/net/wireless
+WIRELESS=${KERNELPATH}/drivers/net/wireless
test -d ${WIRELESS} || { echo "No wireless directory ${WIRELESS}!"; exit
1; }
DST_ATH=${WIRELESS}/ath
@@ -107,7 +107,7 @@
fi
DST_NET80211=${WIRELESS}/net80211
-DST_DOC=${KERNEL_PATH}/Documentation
+DST_DOC=${KERNELPATH}/Documentation
MKDIR ${DST_NET80211}
echo "Copy net80211 bits..."
FILES=`ls ${SRC_NET80211}/*.[ch] | sed '/mod.c/d'`
[EMAIL PROTECTED] src]# cd madwifi-ng-r1552-20060515
[EMAIL PROTECTED] madwifi-ng-r1552-20060515]# patch -p1 -s < ../madwifi-
kernel.patch
[EMAIL PROTECTED] madwifi-ng-r1552-20060515]# cd patches/2.6
[EMAIL PROTECTED] 2.6]# ./install.sh /usr/src/linux-2.6.16.13
Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/ath
Copy ath driver bits...
make: Entering directory `/usr/src/madwifi-ng-r1552-20060515'
if [ -d .svn ]; then \
ver=`svnversion -nc . | sed -e 's/^[^:]*://;s/[A-Za-z]//'`; \
elif [ -s SNAPSHOT ]; then \
ver=`sed -e '/^Revision: */!d;s///;q' SNAPSHOT`; \
else \
ver=`date +%F`; \
fi; \
echo "#define SVNVERSION \"$ver\"" > svnversion.h
make: Leaving directory `/usr/src/madwifi-ng-r1552-20060515'
Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/_ath_hal
Copy ath_hal bits...
Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/_ath_rate
Copy ../../ath_rate/onoe bits...
Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/hal
Copy hal bits...
Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/hal/linux
Creating /usr/src/linux-2.6.16.13/drivers/net/wireless/hal/public
cp: cannot stat `../../hal/public/*.hal': No such file or directory
}}}
Note the other error above. This doesn't happen in 1546, but does in
1550.
Comment:
Similar to my comment in #626, I ask you to attach your patch as a file to
this ticket and sign it off. [wiki:TracTickets#Submittingapatch
TracTickets] give some further information.
--
Ticket URL: <http://madwifi.org/ticket/625>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity
