#746: Compile Breakage On 2.6.18-rc1-mm1
-----------------------------------------------+----------------------------
Reporter: [EMAIL PROTECTED] | Owner:
Type: defect | Status: reopened
Priority: major | Milestone: version 0.9.2
Component: madwifi: makefiles | Version: trunk
Resolution: | Keywords: 2.6.18-rc1-mm1
Patch_attached: 0 |
-----------------------------------------------+----------------------------
Comment (by proski):
The breakage is caused by gregkh-driver-network-class_device-to-
device.patch in 2.6.18-rc1-mm1, which was reverted in 2.6.18-rc1-mm2 (the
explanation was given as "needs work"). Description of the patch:
{{{
From: Greg Kroah-Hartman <[EMAIL PROTECTED]>
Subject: Network: convert network devices to use struct device instead of
class_device
This lets the network core have the ability to handle suspend/resume
issues, if it wants to.
}}}
MadWifi accesses the "class_dev" field directly to copy the physical
device information from the master device to a VAP. This is needed
because there is no GET_NETDEV_DEV or COPY_NETDEV_DEV that would
encapsulate access to the net_device structure.
Possible solutions would be:
1) Do nothing. We cannot anticipate for changes in the network API.
Instead, we should insist that whoever changes it should also provide an
easy way to extract or copy the physical device information.
2) Save the physical device data in MadWifi and get it from there. Don't
rely on existence of class_dev. That's the paranoid approach. We would
protect MadWifi against breakage that happened just in one -mm kernel and
may never happen again.
3) Don't use SET_NETDEV_DEV for VAP.
I prefer to do nothing for now. The responsibility for fixing broken code
should be primarily on the shoulders of those making the change. If code
changes are needed, drivers/net/wireless/hostap/hostap_main.c has similar
code, so we can copy the change from that file.
--
Ticket URL: <http://madwifi.org/ticket/746>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Madwifi-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/madwifi-tickets
