#876: [patch] Prism header - frame length
------------------------------------------+---------------------------------
Reporter: [EMAIL PROTECTED] | Owner:
Type: defect | Status: new
Priority: trivial | Milestone: version 0.9.3
Component: madwifi: driver | Version: trunk
Resolution: | Keywords:
Patch_attached: 1 |
------------------------------------------+---------------------------------
Changes (by mrenzmann):
* milestone: => version 0.9.3
Old description:
> In monitor mode the frame length that the driver gets from the skbuff
> variable is already the length of the MAC frame and does not need a
> correction (minus sizeof(prismheader)).
>
> After the patch the lenght of a MAC frame is reproted correctly in
> ethereal etc. in bigendian like the other fields in the prismheader.
>
> I found this bug because when you have a 802.11 ACK which has always 14
> Bytes ethereal reproted a weird frame length. The problem is that the
> prismheader has a size of 144Bytes so when you do the math 14-144 for an
> uint32 you will get a very large 802.11 ACK Packet.
>
> svn info:
> {{
> Repository UUID: 0192ed92-7a03-0410-a25b-9323aeb14dbd
> Revision: 1705
> Node Kind: directory
> Schedule: normal
> Last Changed Author: proski
> Last Changed Rev: 1705
> Last Changed Date: 2006-08-15 19:14:37 +0200 (Tue, 15 Aug 2006)
> Properties Last Updated: 2006-08-25 13:33:08 +0200 (Fri, 25 Aug 2006)
> }}
>
> Signed-off-by: Oliver Stampfli <[EMAIL PROTECTED]>
New description:
In monitor mode the frame length that the driver gets from the skbuff
variable is already the length of the MAC frame and does not need a
correction (minus sizeof(prismheader)).
After the patch the lenght of a MAC frame is reproted correctly in
ethereal etc. in bigendian like the other fields in the prismheader.
I found this bug because when you have a 802.11 ACK which has always 14
Bytes ethereal reproted a weird frame length. The problem is that the
prismheader has a size of 144Bytes so when you do the math 14-144 for an
uint32 you will get a very large 802.11 ACK Packet.
svn info:
{{{
Repository UUID: 0192ed92-7a03-0410-a25b-9323aeb14dbd
Revision: 1705
Node Kind: directory
Schedule: normal
Last Changed Author: proski
Last Changed Rev: 1705
Last Changed Date: 2006-08-15 19:14:37 +0200 (Tue, 15 Aug 2006)
Properties Last Updated: 2006-08-25 13:33:08 +0200 (Fri, 25 Aug 2006)
}}}
Signed-off-by: Oliver Stampfli <[EMAIL PROTECTED]>
Comment:
Patch looks good, no objections from my side. Anyone up for committing it
to the repos?
--
Ticket URL: <http://madwifi.org/ticket/876>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Madwifi-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/madwifi-tickets
