#944: ToS bits are incorrectly mapped to IEEE 802.11e QoS in v0.9.2
-----------------------------------------------------+----------------------
Reporter: [EMAIL PROTECTED] | Owner:
Type: defect | Status: new
Priority: minor | Milestone: version
0.9.x - progressive release candidate phase
Component: madwifi: other | Version: v0.9.2
Resolution: | Keywords:
Patch_attached: 0 |
-----------------------------------------------------+----------------------
Old description:
> ieee80211_output.c incorrectly maps ToS bits to IEEE 802.11e QoS. The
> "switch ((ip->tos) & 0xFC)" statement does the mapping. It looks at the
> DSCP bits in the ToS byte to assign the correct QoS.
>
> The ToS bits which map to 802.iie access class voice (AC_VO) are 0xc0,
> 0xc8, and 0xe0.
>
> The ToS bits which map to 802.iie access class video (AC_VI) are 0x28 and
> 0x80.
>
> The ToS bits which map to 802.iie access class best effort (AC_BE) are
> 0x00 and 0x60.
>
> The ToS bits which map to 802.iie access class background (AC_BK) are
> 0x08 and 0x40.
>
> The patch below implements the correct ToS to QoS mapping.
>
> 145c145
> < case 0x20:
> ---
> > case 0x40:
> 148c148
> < case 0x28: /* Video */
> ---
> > case 0x80: /* Video */
> 152c152,153
> < case 0x30: /* Voice */
> ---
> > case 0xc0: /* Voice */
> > case 0xc8: /* XXX UPSD */
> 154,155d154
> < case 0x88: /* XXX UPSD */
> < case 0xb8:
New description:
ieee80211_output.c incorrectly maps ToS bits to IEEE 802.11e QoS. The
"switch ((ip->tos) & 0xFC)" statement does the mapping. It looks at the
DSCP bits in the ToS byte to assign the correct QoS.
The ToS bits which map to 802.iie access class voice (AC_VO) are 0xc0,
0xc8, and 0xe0.
The ToS bits which map to 802.iie access class video (AC_VI) are 0x28 and
0x80.
The ToS bits which map to 802.iie access class best effort (AC_BE) are
0x00 and 0x60.
The ToS bits which map to 802.iie access class background (AC_BK) are 0x08
and 0x40.
The patch below implements the correct ToS to QoS mapping.
--
Ticket URL: <http://madwifi.org/ticket/944>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Madwifi-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/madwifi-tickets
