#1702: Changeset 2798 causes ioctls to fail -------------------------------+-------------------------------------------- Reporter: Przemyslaw Bruski | Type: defect Status: new | Priority: critical Component: madwifi: other | Version: trunk Keywords: | Patch_attached: 0 -------------------------------+-------------------------------------------- Hello,
I've noticed that starting with revision 2798 I cannot associate to AP based on that (or later) revision of madwifi. The problem seems to lie in the ioctls that accept key index as a parameter. When this parameter is set to -1/65535 (which is expected by the caller to be IEEE80211_KEYIX_NONE), madwifi compares it against the new constant modified in the mentioned changeset, equal to 255. I believe that simply backing out 2798 will fix the issue and not introduce other problems (it should be safe, since the compiler won't let compare 16bit KEYIX_NONE against 8bit value from hostapd anyway, so the cast will always have to be added). Alternatively, ioctl key index parameters have to be sanitized for comparisons with 8bit KEYIX_NONE before use. I think that using 255 as KEYIX_NONE in a 16bit variable is a workaround anyway and it would be better to stick to 65535 and cast the keyix from ieee80211req_del_key instead. I think this problem was already reported in #1693 where two problems (association problem and oops) are reported. #1693 was diagnosed to contain only the oops. bye, Przemyslaw Bruski -- Ticket URL: <http://madwifi.org/ticket/1702> madwifi.org <http://madwifi.org/> Multiband Atheros Driver for Wireless Fidelity ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Madwifi-tickets mailing list Madwifi-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/madwifi-tickets
