#2050: Save memory on vap ptrtable malloc
-----------------------------+----------------------------------------------
 Reporter:  [EMAIL PROTECTED]  |             Type:  enhancement
   Status:  new              |         Priority:  minor      
Component:  madwifi: HAL     |          Version:             
 Keywords:                   |   Patch_attached:  0          
-----------------------------+----------------------------------------------
 While reading the source of if_ath.c, I've stumpled across a wrong malloc.

 {{{
 -               kzalloc(ath_maxvaps * sizeof(struct ieee80211vap),
 GFP_KERNEL);
 +               kzalloc(ath_maxvaps * sizeof(struct ieee80211vap*),
 GFP_KERNEL);
 }}}

 As a side note: Is it really helpful to have two pointers to the same data
 everywhere? Why not use a simple type cast instead of the ubiquitous "avp
 = dev->priv; vap = &avp->av_vap;"...

-- 
Ticket URL: <https://madwifi.org/ticket/2050>
madwifi.org <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity
-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Madwifi-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/madwifi-tickets

Reply via email to