On 25.10.2011 19:39, [email protected] wrote: > Revision > 158082 > Author > matteo > Date > 2011-10-25 18:39:21 +0200 (Tue, 25 Oct 2011) > > > Log Message > > upgraded to version 1.13.4
[...] > -Patch3: wget-1.8-no-solaris-md5.h.patch > -Patch4: wget-1.11-etc.patch > -# The following patch is needed for authenticated sites where login can have > '@': > -Patch7: wget-1.10-url_password.patch > -Patch9: wget-1.11-logstdout.patch > -Patch10: wget-1.10-referer-opt-typo.patch > -Patch11: wget-1.9.1-fix-fr-translation.patch > -# needed by urpmi, inspired by > http://matthewm.boedicker.org/code/src/wget_force_clobber.patch > -Patch13: wget-1.11-add-force-clobber-option.patch > -Patch14: wget-1.12-CVE-2010-2252.diff > +Patch0: %{name}-ssl-certs.patch > +Patch1: %{name}-pl.po-update.patch > +Patch2: %{name}-1.13.4-fix-fr-po.patch > +Patch3: %{name}-forceclobber.patch > +Patch4: %{name}-logtostdout.patch > +# patches 5 and 6 needs patch 3 to be applied before > +Patch5: %{name}-urlpassword.patch > +Patch6: %{name}-referertypo.patch > +Patch7: %{name}-1.13.4-etc.patch Patches have been reordered and renamed without any mention or explanation in the changelog entry. Even worse, you've removed no-solaris-md5.h.patch and CVE-2010-2252.diff without any explanation. Also, you've added wget-ssl-certs.patch and fix-fr-po.patch without any explanation. Of those, wget-ssl-certs.patch *breaks* SSL certificate handling since it replaces *correct* paths with *wrong* paths. Are you blindly adding patches from some another distribution without checking? In addition, you've removed the .spec comments of some patches without any explanation. [...] > # all tests must pass (but where are they?) > -%check > -make check > +#%check > +#%__make check Why is this commented, again without any explanation? Please use svn propedit to edit the changelog of this commit and revert the inappropriate parts. -- Anssi Hannula
