Le 03/01/2012 17:18, Jani Välimaa a écrit :
Morevoer, it mixes pure cosmetics changes, as some of those macros just expand to the command itself, as install vs %__install, with behaviour changes, as other macros expand to the command with additional arguments, as make vs %make, which is actually make -j.@@ -11,7 +11,7 @@ Group: System/Kernel and hardware BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot URL: http://www.codemonkey.org.uk/projects/x86info/ -Source0: %{name}-%{realver}%{?cvsdate:-%{cvsdate}}.tar.bz2 +Source0: %{name}-%{realver}%{?cvsdate:-%{cvsdate}}.tgz Patch0: x86info-1.17-intel-flags.patch Patch1: x86info-1.17-intel-caches.patch Patch2: x86info-1.17-cpuid-with-ecx-input.patch @@ -33,17 +33,18 @@ %setup -q -n %{name}-%{realver}%build -make CFLAGS="%{optflags}" +#make CFLAGS="%{optflags}" +%make %install -rm -rf %{buildroot} -install -d %{buildroot}%{_bindir} -install -d %{buildroot}%{_mandir}/man1 -install -m755 %{name} %{buildroot}%{_bindir}/ -install -m755 %{name}.1 %{buildroot}%{_mandir}/man1/ +%__rm -rf %{buildroot} +%__install -d %{buildroot}%{_bindir} +%__install -d %{buildroot}%{_mandir}/man1 +%__install -m755 %{name} %{buildroot}%{_bindir}/ +%__install -m755 %{name}.1 %{buildroot}%{_mandir}/man1/I think this is pretty much opposite what everyone else is doing. IMHO this also makes .spec harder to read.
-- BOFH excuse #62: need to wrap system in aluminum foil to fix problem
