19.03.2012 14:49, Colin Guthrie kirjoitti: > 'Twas brillig, and Anssi Hannula at 19/03/12 12:36 did gyre and gimble: >> 19.03.2012 14:32, Guillaume Rousse kirjoitti: >>> This happens whenever a package with systemd support is updated: >>> >>> installation de nginx-1.0.14-1.mga2.x86_64.rpm depuis /var/cache/urpmi/rpms >>> Préparation ... ############################################# >>> 1/1: nginx ############################################# >>> Warning: Unit file of created job changed on disk, 'systemctl --system >>> daemon-reload' recommended. >>> >>> First question: should we not make rpm-helper automatically do it, if >>> not already done ? >>> >>> Second question: could we ensure the message is not displayed if handled >>> automatically ? >> >> Looks it is handled (somewhat): >>> [anssi@sigma ~]$ cat /var/lib/rpm/filetriggers/systemd-daemon-reload.filter >>> ^./lib/systemd/system/ >>> ^./etc/systemd/system/ >>> [anssi@sigma ~]$ cat /var/lib/rpm/filetriggers/systemd-daemon-reload.script >>> #!/bin/sh >>> if /bin/mountpoint -q /sys/fs/cgroup/systemd; then >>> if [ -x /bin/systemctl ]; then >>> /bin/systemctl daemon-reload >/dev/null 2>&1 || : >>> fi >>> fi > > Yup, the filetrigger handles this generically. > >> However, maybe it is done too late? The Warning comes from %post, while >> filetriggers are run at %posttrans time. >> Maybe daemon-reload should be run in %_post_service instead? > > I thought I had put it in %_post_service... hmmmm. > > I guess it should go before this line: > /bin/systemctl --quiet try-restart $units > > > The file trigger is to catch when a unit changes. That may or may not > cover services specifically (could be socket or mount units etc.) thus > %_post_service may or may not be called. So I think the file-trigger is > still valid. > > > > As for silencing the message I agree. Not quite sure how that message is > generated however....
Well, no need to silence the message if you fix the issue that causes it to appear in the first place :) -- Anssi Hannula
