05.04.2012 10:58, Thierry Vignaud kirjoitti: > On 5 April 2012 04:51, <[email protected]> wrote: >> Restructure AMD/ATI Cards+ entries for HD 2000 and newer, to separate >> those that support usermode modesetting while adding the necessary >> FIRMWARE and DRIVER_NO_FIRMWARE entries as per mga bug #3466, and to >> disable any remaining radeonhd assignments. > > (...) > >> - } elsif (member($d_pci->{$_}[0], ($ati_free_only, >> $ati_rhd_only)) && $d_in->{$_}) { >> + } elsif (member($d_pci->{$_}[0], ($ati_free_only)) && >> $d_in->{$_}) { > > should be the following since list is reduced to one item; > } elsif ($d_pci->{$_}[0] eq $ati_free_only && $d_in->{$_}) { > >> - } elsif (member($d_pci->{$_}[0], ($ati_driver_rhd, >> $ati_driver_vesa, $ati_rhd_only)) && $d_in->{$_}) { >> + } elsif (member($d_pci->{$_}[0], ($ati_driver_vesa)) && >> $d_in->{$_}) { > > should be simplified likewise here > >> # support added for pre-existing entry, handle: >> - if (member($d_pci->{$_}[0], ($ati_driver_rhd, >> $ati_driver_vesa))) { >> - $d_pci->{$_}[0] = $ati_driver; >> - } elsif ($d_pci->{$_}[0] eq $ati_rhd_only) { >> - $d_pci->{$_}[0] = $ati_free_only; >> + if (member($d_pci->{$_}[0], ($ati_driver_vesa))) { >> + $d_pci->{$_}[0] = > > idem >
Well, my instinct was to not simplify them as I remembered that I had previously had to unsimplify them :) but that isn't indeed a good enough reason for it, changed now. Thanks. -- Anssi Hannula
