On 15 May 2012 17:52, Thierry Vignaud <[email protected]> wrote: >> - fix updates installation. installUpdates was relying on >> urpmi_add_all_media >> return value different than 0, which was always 0 due to the 'undef $wait' >> line > > This is bogus: > - if we don't have rpmdrake installed > - if we're in the text mode install. > > What you wanted was probably this: > > my $val = run_program::rooted($::prefix, $binary, '>>', $log_file, > '2>>', $log_file, @options); > undef $wait; > $val; > } > > Also your description in NEWS is ... undescriptive > "fix detecting if adding update media succeeded" would have been better
Also, again perl-install/NEWS is for drakxtools and install/NEWS is for drakx installer. You changed code only used by the installer, hence it should have been in install/NEWS not NEWS
