Thomas Backlund a écrit : >>> <[email protected]> writes:
>> Hello ! >> Some news : >> Indeed it was more difficult than I thought : >> There were 21 different Makefile.in in 21 directories to modify : >> I wrote a patch that replaces >> -LDFLAGS = @LDFLAGS@ >> by >> +LDFLAGS = @LDFLAGS@ -lpthread >> in each of them... >> > > And now you are overlinking :) > > You only need to patch the Makefile(s) that is responsible for > building the code that relies on pthread > Hey ! You ! you are a happiness breaker :-( > >> Now each Makefile contains : >> LDFLAGS = -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -Wl,-O1 >> -Wl,--build-id -Wl,--enable-new-dtags -lpthread >> >> >> And I discover that my first workaround was indeed bad : >> I used >> %build >> %configure2_5x >> %make LDFLAGS="-lpthread" >> >> instead of >> %build >> %configure2_5x >> %make >> >> this allowed to package and I felt happy ;) ... but wrongly happy :( >> >> >> Now that I use a correct LDFLAGS I got new errors about other undefined >> references (thanks to --as-needed option) >> ... and I feel sad :( >> >> There came now undefined references to 'dlopen' 'dlerror' 'dlclose' >> >> I had to add -ldl to each Makefile.in >> > > And overlinking again :) > Argh ! You killed me ;-( >> And now it's OK >> >> Thanks to all of you ! I'm now less ignorant than I was ... >> >> But packaging for Mageia will need more skill and more time than for >> Mandriva ... and more patches ! (hope it's worth of it) >> > > Of course it is worth it... > By finding and fixing issues like this (and also send the fix upstream) > the quality of the code is improving... > > -- > > Thomas > You gave me some more work indeed : >> I will provide my spec and patch files to anyone (perhaps through >> bugzilla with a package request) > Mageia will have to wait for sometime :... There are 21 makefiles There are 0 or 1 or 2 links to add to them (but which of them really need the added links ?) Than means some combinations to try : 2 square to the power of 21 = 2097152 if I blindly test all of them ! If I win early I will try the casino ;-) I will try a rational approach to decrease the number of tests to do... Anyway... Did you think that inactivating the --as needed option will imply so much time to build only one package ? I really am afraid with this ! > > Regards Philippe
