On 8 Nov 2007, at 18:33, Andy Armstrong wrote:

We've recently released Test::Harness 3.00 which is a little stricter about what it sees from a test suite. As a result there are two tiny problems with the PerlMagick tests.

1) Makefile.PL may cause the wmf tests to run twice. Test::Harness 3.00 faults this
2) t/setattribute.t emits a malformed plan line: "1..71)"

This patch fixes both problems:




I mailed Bob Friesenhahn about the t/setattribute.t issue and he has replied. I'm including the patch here because I'm unsure who the best people to tell are.

Hope that's all OK. Thanks for ImageMagick :)

I guess that'll be this patch then:




Or if that gets stripped:

Index: PerlMagick/t/setattribute.t
===================================================================
--- PerlMagick/t/setattribute.t (revision 8648)
+++ PerlMagick/t/setattribute.t (working copy)
@@ -4,7 +4,7 @@
 #
 # Contributed by Bob Friesenhahn <[EMAIL PROTECTED]>
 #
-BEGIN { $| = 1; $test=1, print "1..71)\n"; }
+BEGIN { $| = 1; $test=1, print "1..71\n"; }
 END {print "not ok 1\n" unless $loaded;}
 use Image::Magick;
 $loaded=1;
Index: PerlMagick/Makefile.PL
===================================================================
--- PerlMagick/Makefile.PL      (revision 8648)
+++ PerlMagick/Makefile.PL      (working copy)
@@ -27,7 +27,7 @@
 # Compute test specification
 my $delegate_tests='t/*.t';
 my $delegate;
-foreach $delegate (qw/bzlib fontconfig freetype gs gvc jpeg jp2 lcms openexr png rsvg tiff wmf x11 xml wmf zlib/) { +foreach $delegate (qw/bzlib fontconfig freetype gs gvc jpeg jp2 lcms openexr png rsvg tiff wmf x11 xml zlib/) {
   if ( -d "t/$delegate" ) {
     if ($delegate =~ /x11/) {
       if ( defined $ENV{'DISPLAY'} ) {

Or you could just manually make the edits in question :)

--
Andy Armstrong, Hexten




_______________________________________________
Magick-developers mailing list
Magick-developers@imagemagick.org
http://studio.imagemagick.org/mailman/listinfo/magick-developers

Reply via email to