On 2010-01-23 13:59 +0000, Hannu Koivisto wrote: >> The following warning from compiling magit.el in emacs 23.1.91 seems >> suspicious. >> >> In magit-run*: magit.el.gz:1010:11:Warning: `save-excursion' defeated >> by `set-buffer' > > I don't get such warnings but I have a bit older Emacs version, > 23.1.50. I get a few other warnings, though. If I try to grep sources > of this version, I can find only one "defeated" word in some news > file.
The compiler warning is introduced later than 23.1.50 to warn package author about the faulted use of (save-excursion (set-buffer ...) ...). It should be changed to (with-current-buffer BUF ... ) and save-excursion should be inserted inside it where it is needed. Leo -- H A P P Y H O L I D A Y S!
