At Tue, 16 Feb 2010 13:57:41 +0100, Dominique Quatravaux wrote: >> it looks like the refactoring in revision c315191639f27 inadvertently >> suppressed the application of the magit-diff-file-header text >> property. Could you please bring it back?
On Wed, Mar 10, 2010 at 11:12 PM, Philip Jackson <[email protected]> wrote: > Just to be clear, the face is applied to the line that looks like > > diff --git a/magit.el b/magit.el > > that? That's indeed what c315191639f27 used to do according to my cursory reading of the code (though I didn't try to actually test it under Emacs). However, if you are open to revisiting this, I'd like to have magit-diff-file-header apply to the next 2 lines instead, ie --- a/magit.el blah blah +++ b/magit.el blah blah because I'm actually trying to make the diffs in the magit window look exactly like Emacs' diff-mode. I have this in my .emacs: (custom-set-faces '(magit-diff-file-header ((t (:inherit diff-header)))) '(magit-diff-hunk-header ((t (:inherit diff-header)))) '(magit-diff-add ((t (:inherit diff-added)))) '(magit-diff-del ((t (:inherit diff-removed)))) '(magit-diff-none ((t (:inherit diff-context)))) '(magit-item-highlight ((t)))) but of course, the second line with magit-diff-file-header currently has no effect. Thanks in advance! Cheers, -- Dominique Quatravaux +41 79 609 40 72
