On 2010-04-28 22:46 +0100, Óscar Fuentes wrote:
> At first I liked the buttons on the VC log and actually tried to
> implement them on magit, but failed due to keymap issues. Now I think
> that using buttons is a bad idea. Suppose that the log is showing the
> last 100 entries of a large branch and you want to see some entry that
> you think is within the last 1000 revisions or so. With the buttons, you
> have to press TAB RETURN and wait for the refresh four times for showing
> at least 1000 revisions. This sucks.

I would divide the labour differently. The button is sort of like "turn
to next page" thingie and make it stay that way so that it is intuitive.

The scenario you described could be built into magit-log. I already see
a way to do so, namely, extend C-u M-x magit-log, if user provides a
number (say, < 9999) show that many entries.

>> Here is an example of how slime implements its function browser
>> (inspector); vc does something similar.
>
> I don't think that a function browser is a valid UI model for a log
> display.

I doubt that.

And I was just showing you an example of the button how it is placed and
colored.

Leo

Reply via email to