On 2010-05-05 12:00 +0100, Philip Jackson wrote: > Hi Magiters, > > It's probably time for a Magit release. Is there anything that is > sorely missing from master that should be in 0.8.0? If not I'll tag > and release from HEAD soon. > > BTW, I can't reach Marius so I'm going to have to host the files on my > site temporarily (personally I'd advocate a move to github so we can > keep the homepage there, but that's defiantly a call for Marius). > > Cheers, > Phil
parse-time is required for magit-hunk-item-target-line due to its use of parse-integer. eval-when-compile won't work. BTW, I think the list of requires at the beginning of the file should be cut down. For example some are only used by a function or two and should be loaded when needed. For emacs 23, declare-function is convenient. Why magit defvar last-point? Is it used by other emacs variants? If not please rename it to reside in magit namespace. Best wishes, Leo >From eaaaaf7ad3ab779c3ee07af626b27144ff8fe8bb Mon Sep 17 00:00:00 2001 From: Leo <[email protected]> Date: Wed, 5 May 2010 14:16:09 +0100 Subject: [PATCH] Require parse-time --- magit.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/magit.el b/magit.el index 7c0b6d9..06cc563 100644 --- a/magit.el +++ b/magit.el @@ -56,7 +56,7 @@ ;; - 'Subsetting', only looking at a subset of all files. (eval-when-compile (require 'cl)) -(eval-when-compile (require 'parse-time)) +(require 'parse-time) (require 'log-edit) (require 'easymenu) (require 'diff-mode) -- 1.7.0.4 -- CCL-USER> _
