Rémi Vanicat <[email protected]> writes: >>> P.S docstring and value are the wrong way around for >>> `magit-custom-options'. >> >> Not sure what this means. >> >> (I'm not an Elisp experienced programmer) >> > > When you defined magit-custom-options you wrote
[snip] Thanks. > By the way, please put meaningful docstring, it can be used by people > wanting to customize it, but also by people trying to fix bugs, or > trying to add some functionality and that could find useful to know what > the variable is used for. Agreed. Docstrings is what I plan to do as soon as the code stabilizes. Rigth now I'm not sure that magit-custom-options is a good name, nor even the right way for doing the job. P.S. Just added some options to the log menu (--author, --branches, etc) plus --grep, which makes magit-log-grep unnecessary. It is now possible to say things like "show commits by Joe on all branches, long format.) However, some commands, like `log', have so many options that the screen space is too small for displaying them on some machines (i.e. netbooks) We could partially solve this issue by displaying key --option instead of key Tiny and mostly useless description (--option)
