Pekka Pessi <[email protected]> writes: > 2010/5/19 Óscar Fuentes <[email protected]>: >> Pekka Pessi <[email protected]> >> writes: >> >>> + cmd "/usr/bin/env" >> >> This is not portable. Does the current implementation work on Windows ? > > I have no idea, but I think you need POSIXish environment to properly > run git, like cygwin.
Yes, but Emacs does not know about those POSIXish environments. Something that could work everywhere is (locate-file "env" exec-path exec-suffixes) There is one last trick, though: msys-cygwin can be installed in a way that only git and gitk are reachable through PATH, and some people does not put git on the PATH at all and sets the variable `magit-git-executable'. Phil: if this is the only issue with the patch, commit it and I will submit a fix later.
