David Abrahams <[email protected]> writes: > I just hit RET in a *magit-commit* window and got: > > Symbol's value as variable is void: parse-time-digits > > I think there's a (require 'parse-time) missing somewhere.
This one is strange because is see no use of parse-time-digits in the source code. We do use parse-integer, but the correct action seem to me to drop this dependency with the attached patch.
commit 8b471792ef907a3386c82088121fe27a824508c3 Author: Rémi Vanicat <[email protected]> Date: Wed May 26 20:20:18 2010 +0200 Remove a decency on parse-time string-to-number is the function to call to read an integer Modified magit.el diff --git a/magit.el b/magit.el index 0f30435..f88edc2 100644 --- a/magit.el +++ b/magit.el @@ -66,7 +66,6 @@ ;; - 'Subsetting', only looking at a subset of all files. (eval-when-compile (require 'cl)) -(eval-when-compile (require 'parse-time)) (require 'log-edit) (require 'easymenu) (require 'diff-mode) @@ -2288,7 +2287,7 @@ in the corresponding directories." (goto-char (magit-section-beginning hunk)) (if (not (looking-at "@@+ .* \\+\\([0-9]+\\),[0-9]+ @@+")) (error "Hunk header not found")) - (let ((target (parse-integer (match-string 1)))) + (let ((target (string-to-number (match-string 1)))) (forward-line) (while (< (line-number-at-pos) line) ;; XXX - deal with combined diffs
-- Rémi Vanicat
