Philip Jackson <[email protected]> writes: [snip]
> I'm not sure prefix args fit with key-groups anymore. What do others > think? Prefix args are unintuitive and the user is forced to read the documentation for knowing about its existence and semantics. So the less they are used, the better. My implementation supports prefix args because backwards compatibility with the existing magit functions. For the specific case discussed on this thread, the problem can be resolved by adding the --repo git option to the list of options for "push". More generally, we can add support for git arguments that do not correspond to git options. Example: magit key-group option item with the text "<repository>". When the list of commands for passing to git is contructed, the text "<repository>" is ignored and the repository entered by the user is appended to the command line. This is very easy to implement. One thing to note is that magit key-group options are appended to the git command line on the same order they are enumerated on the list `magit-menu', so the "<repository>" must appear after all the other options for the group "Push".
