Samuel Wales <[email protected]>
writes:

> In other words, I just want magit the way it was,

Phil just changed the default back to magit-builtin-completing-read
which uses completing-read (with slightly different prompting, but
this is no different from what Magit did before) so if ido-hacks
overrides completing-read, things should work out of the box.

If the prompt trickery in magit-builtin-completing-read interferes
with ido, and I imagine it might since it did with iswitchb and
that's why I wanted to refactor that out of
magit-completing-read(-function) calling code, then it might be
better to set magit-completing-read-function to completing-read.
But since it didn't bother you before, perhaps there is no need.

> because ido-hacks already does what is desired with this patch.

Well, that's not entirely accurate.

-- 
Hannu

Reply via email to