On 30/03/11 20:10, PJ Weisberg wrote:
On 3/29/11, Rémi Vanicat<[email protected]> wrote:
Dave already replied, but let me tell it in the point of view of one of
the upstream commiter: GitHub pull request is a place where we can
easily review code from others. We can comment on it, or just merge
it. Discussion on the mailing list is mostly useful when there is an
unresolved problem with your code, and you now about it. (For example,
the doomsday question: "what key-binding should I use for this?")
Thanks, Dave and Rémi. I was really just reluctant to mark things
"done, ready for merge" without discussion and inundate the Pull
Requests section with half-baked patches.
Thanks for merging my simple fix for issues 53& 54. I don't suppose
there's a standard way to communicate when someone is working on a
given issue, is there?
Not really. So far there's not been an issue with people scrambling to
fix the same issue (alas). If I were to suggest a way how about just
commenting on the issue?
Your work is much appreciated, by the way.
Cheers,
Phil
