Ted Zlatanov <[email protected]> writes: > On Fri, 27 May 2011 20:39:28 +0200 Rémi Vanicat <[email protected]> wrote: > > RV> I've recently pushed to master a modification to this part of the > RV> code. Could you integrate with it? > > Attached. > > RV> Note also that when one is reading "foo's password:" it is actually ssh > RV> asking for a password when there is no ssh-key. When it's git that do the > asking, it > RV> just ask for "Password:" (hence the bug for the original poster of this > RV> thread). > > OK, I didn't get that. See my TODO comments regarding more things we > can do there, especially the origin.url if we can get it.
We are not always pulling from origin. We should care to not falsely ask the wrong password... > > I changed things a bit so please let me know if any of the code is wrong > or broken. When this iteration is acceptable I'll add the backwards > compatibility calls to `auth-source-user-or-password' as well. > > Also my original message asked about askpass; that's much more reliable > than parsing CLI output and works in Unix and Windows (with msysgit at > least). Could Magit support that? For this to work we need a script that call Something like --8<---------------cut here---------------start------------->8--- #!/bin/sh emacsclient -e "(magit-ask-password \"$*\")" --8<---------------cut here---------------end--------------->8--- where magit-ask-password would be a new function dealing with the actual asking. Then if we setenv SSH_ASKPASS to it, both git and ssh will use it for asking password. (If we want this only for git it's GIT_ASKPASS we have to set) problems with this are: - this might not work as easily on windows and Mac OS X - we will need to install this script somewhere. It make magit installation more complex, particularly for user of the git version and those who install themselves. An advantage would be to get ride of the problem that make us use magit-process-connection-type and just use nil for its value. > It may be productive to give me commit access to the Github repo as I > have some other Magit things in my queue. It's not a big deal, just > don't make me do the Github-specific fork+pull request procedure :) I will look at your code later, but please, do fork and request pull. It's really easy, and it's our standard procedure for dealing with new contributor and review there code. It's also the place where I go when I want to look at code review I wanted to do and forget. [...] -- Rémi Vanicat
