On Tuesday, June 21, 2011, Leo <[email protected]> wrote:
> I seem to recall I reported some bug related to that setting. It is in
> the archive. Unfortunately google groups are blocked from where I am.
>
> Leo

I found that thread.  The bug you reported was that Magit was setting
the value of line-move-visual globally instead of in its own buffer.
Marius Vollmer said "I was
messing with line-move-visual primarily to work around some bugs
somewhere related to hiding and showing of text,"

I don't know what the begs were, or if this successfully works around
them, I wonder if there's a better way to fix them than messing with
this setting.

On Tuesday, June 21, 2011, Rémi Vanicat <[email protected]> wrote:
> I believe it is because the author of those line wanted to remove some
> possibly bad display of diff in some hunk as:
...
> That said, the use of colored diff render this justification less
> appealing. Emacs diff mode don't do that.

Yeah, magit-diff-added and magit-diff-none looked the same on a dark
background before we changed them to inherit from the standard diff
faces.

I'm thinkng of removing those two settings on my local system for a
couple weeks to see if any bugs surface, then commiting it once I'm
pretty sure nothing's broken.  Sound like a plan?


-- 

-PJ

Reply via email to