Hi.  I've been using magit for a little while now, and I quite like it.
I've accumulated a small set of changes that I thought others might be
interested in in my fork of the magit repo[1] in the "work-changes"
branch.  I'm not sure what the preferred mechanism for asking folks to
take a look at proposed changes is (and I'm also new at github), so
please let me know if there's some other way I should present these.

Anyway, here's a very brief summary of what I've been fiddling with.
Ths SHAs correspond to my github repo, and these are in oldest to newest
order.  In all of these, I've tried to add docstrings where needed.

d484b9e7: teach magit-diff-with-mark to reverse start and end commits

 - With a prefix argument, diff-with-mark will reverse the start and end
   commits.  I found that this made it a bit more convenient if I
   happened to get the mark and point the wrong way around.

a4c4226d: allow customization of git diff output

 - Add two customization variables, magit-diff-hunk-format-options and
   magit-diff-commit-options.  
 
 - 'magit-diff-hunk-format-options' are given to all diff-generating
   commands, and my thought was that they affect mostly just the actual
   diff format itself.

 - 'magit-diff-commit-options' is given when comparing two trees
   (mostly, I think, via "git diff" and "git log"), and is meant to
   include things like --dirstat, etc.  I'm not especially happy with
   the name of this variable, so alternate suggestions would definitely
   be appreciated.

a9327345: visit the repo version of a file from a diffbuf ...

 - when you visit a hunk or diff inside of a diffbuf comparing two
   trees, bring up the version of the file from the repository, not the
   working directory.

8ae9f6f1: don't apply a region of a hunk with no context

 - when playing with applying a region of a hunk, it seemed error prone
   if there was zero context, so I introduced an error in that case.

301071a2: move knowledge of "--reverse" into magit-apply-hunk-item*

 - knowledge of "--reverse" seemed a bit disperse with respect to
   magit-apply-hunk-item*, so I tried to centralize it a bit more.

Thanks in advance for any feedback you might have.

Dale.

[1] git://github.com/dalehagglund/magit.git

Reply via email to